pull_requests: 542477484
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 542477484 | MDExOlB1bGxSZXF1ZXN0NTQyNDc3NDg0 | 4707 | closed | 0 | APIv2: pass user defined `filename_or_obj` to backends as is | 226037 | - [x] Related to #4309 - No test added, but all tests pass. - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - No new functions/methods. **The change affects only APIv2.** Pros: - `open_dataset` passes the dataset description object `filename_or_obj` to the backends without fiddling with it. This is more and more important as several backends know how to open `dict`s, `file`'s `str`s that are not paths (*rasterio* for example accepts GDAL strings that are not paths and that is one of the reasons `engine="rasterio"` cannot be used in `open_dataset`) Cons: - at the moment backends expect paths to always be absolute, not sure if they use this info. | 2020-12-18T11:14:05Z | 2020-12-22T14:14:18Z | 2020-12-22T14:14:18Z | 2020-12-22T14:14:18Z | 7e2e22ae0f0ebece09de807245d467ee4847d4fa | 0 | 13473f0af5b36efb5a641a6d9ab971687749e4e5 | 7355c350a88ec6892c5e9ccdf8dee5ef532036be | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4707 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests