pull_requests: 498123546

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
498123546 MDExOlB1bGxSZXF1ZXN0NDk4MTIzNTQ2 4489 open 0 Alignment with tolerance2 10563614 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #2217 - [x] Tests added - [ ] Passes `isort . && black . && mypy . && flake8` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` Reading #2217, I've implemented fast algorithms for union and intersection of arrays with numerical tolerance. This works fine in the "normal" case, when each array has all its values different (outside the tolerance) and the first and second arrays have some values in common within the tolerance. Conversely, the behavior is not well defined when one array has some values that are within the tolerance (or are equal) of each other. In this case, the behavior of union and intersection is not well defined anyway. The "bad" cases could be checked to raise an Exception (duplicate values within the tolerance), but this is not implemented yet. I've also implemented a function to test index equality within the tolerance. At last, the logic of xarray.align has been changed to deal with the tolerance. It was not possible to avoid some changes in align. I'd appreciate some tests and code review, because there are certainly some rough corners I've not though about. 2020-10-05T21:17:53Z 2023-12-14T19:22:57Z     7f6a061bace18038bde8d3b76869bf22c4aa4dd4     0 368c7d4e79dea8689bbd57cc7745ce1830e3e32e d1e4164f3961d7bbb3eb79037e96cae14f7182f8 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/4489  

Links from other tables