pull_requests: 497857104
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 497857104 | MDExOlB1bGxSZXF1ZXN0NDk3ODU3MTA0 | 4485 | closed | 0 | Handle scale_factor and add_offset as scalar | 500246 | The h5netcdf engine exposes single-valued attributes as arrays of shape (1,), which is correct according to the NetCDF standard, but may cause a problem when reading a value of shape () before the scale_factor and add_offset have been applied. This PR adds a check for the dimensionality of add_offset and scale_factor and ensures they are scalar before they are used for further processing, adds a unit test to verify that this works correctly, and a note to the documentation to warn users of this difference between the h5netcdf and netcdf4 engines. - [x] Closes #4471 - [x] Tests added - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2020-10-05T13:31:36Z | 2020-10-16T21:20:14Z | 2020-10-11T20:06:33Z | 2020-10-11T20:06:33Z | 569a4da18229aed391886ef768132f3d6d64fb30 | 0 | 49d03d246ce657e0cd3be0582334a1a023c4b374 | 45aab423b61c99278dd9b4d8a21915647afae623 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4485 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests