pull_requests: 492931397
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 492931397 | MDExOlB1bGxSZXF1ZXN0NDkyOTMxMzk3 | 4458 | closed | 0 | Autodetect the engine only when `engine=None` | 226037 | Always use the `engine` explicitly selected by the user and perform auto detection only when `engine=None`. - [x] Closes #4457 - [x] Tests added - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] No new functions/methods The refactor complexity stems mostly from moving or duplicating some logic from `_get_engine_from_magic_number` to the backend stores. The current, rather ugly, code minimizes changes to the error conditions and messages. Later in the backend refactor the plugins will provide the functionalities to identify the format from the file content and the duplication should be eliminated. @jhamman do you think I need to acknowledge the CZI sponsorship in the changelog? | 2020-09-25T08:53:27Z | 2020-12-10T10:30:56Z | 2020-09-28T15:42:01Z | 2020-09-28T15:42:01Z | f821fe20595c3700375ccecebf88e01a61444777 | 0 | ae766a4039a656c135357dbbd5e307111fac6333 | c0399d3de144bf26a0e6b5a8abe2b1560576c552 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4458 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests