pull_requests: 486197524
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 486197524 | MDExOlB1bGxSZXF1ZXN0NDg2MTk3NTI0 | 4418 | closed | 0 | Add try/except logic to handle renaming of cftime datetime base class | 6628425 | `cftime` is planning on renaming the base class for its datetime objects from `cftime.datetime` to `cftime.datetime_base`. See discussion in https://github.com/Unidata/cftime/issues/198 and https://github.com/Unidata/cftime/pull/199. This PR adds the appropriate logic in xarray to handle this in a backwards-compatible way. In the documentation in places where we refer to `` :py:class:`cftime.datetime` `` objects, I have modified things to read ``` ``cftime`` datetime ```. Being more generic is probably better in any case, as in most instances we do not explicitly mean that the base class can be used, only subclasses of the base class. cc: @jswhit - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2020-09-13T15:25:53Z | 2020-09-19T13:30:02Z | 2020-09-19T13:29:14Z | ff68600f14c23b8b5e88f1cdbea268769e2e57e3 | 0 | 62c993e9a93ce0d897e068fe671121eebf71c975 | 66ab0ae4f3aa3c461357a5a895405e81357796b1 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4418 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests