pull_requests: 471878653
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
471878653 | MDExOlB1bGxSZXF1ZXN0NDcxODc4NjUz | 4365 | closed | 0 | Silence plot warnings | 10194086 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Towards #3266 - [x] Tests added - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` I gave a try to silence some of the warning for the plotting functions. I brought it down from 67 to 5 (4 of which come from external libraries). - [x] `MatplotlibDeprecationWarning: The 'extend' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later.` - [x] `MatplotlibDeprecationWarning: You are modifying the state of a globally registered colormap. In future versions, you will not be able to modify a registered colormap in-place. To remove this warning, you can make a copy of the colormap first. cmap = copy.copy(mpl.cm.get_cmap("viridis"))` - [x] `MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.` - [ ] `MatplotlibDeprecationWarning: shading='flat' when X and Y have the same dimensions as C is deprecated since 3.3. Either specify the corners of the quadrilaterals with X and Y, or pass shading='auto', 'nearest' or 'gouraud', or set rcParams['pcolor.shading']. This will become an error two minor releases later.` See #4364 - [x] `UserWarning: Requested projection is different from current axis projection, creating new axis with requested projection.` - [x] Made sure all figures are closed at the end of a test. - [x] Added a meta-test to ensure all figures will be closed if tests are added in the future I cannot exclude that one of these changes has an effect on the plots that is not tested in the suite... Tests pass locally for py38 and py36-bare-minimum. | 2020-08-21T22:21:40Z | 2020-08-24T16:05:13Z | 2020-08-24T16:00:42Z | 2020-08-24T16:00:42Z | d3536b9a6e92f97401865d9daf5d48cee52e40da | 0 | f87631a3d803ce2bd00cd10b6b9fac37d258d5bf | 43a2a4bdf3a492d89aae9f2c5b0867932ff51cef | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4365 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests