pull_requests: 462990785
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
462990785 | MDExOlB1bGxSZXF1ZXN0NDYyOTkwNzg1 | 4310 | closed | 0 | Remove all unused and warn-raising methods from AbstractDataStore | 226037 | - [x] Related but really orthogonal to #4309 - [x] Remove code, but keeps all existing tests passing (on MacOS with pandas=1.0.5) - [x] Passes `isort . && black . && mypy . && flake8` - [x] No user / developer visible changes are expected @shoyer this could be the first pass of the simplification of the current backend API. It not needed for #4309, but it make more obvious that we'd be free to keep the AbstractDataStore class if we wanted to. The reason the change can be considered reasonably innocuous is that warnings would have been printed on access to any of the removed methods, but you never know. Your call (but I'd love to have a delete-only contribution to *xarray* :D). Please note that: 1. this change is the absolute lowest hanging fruit, 2. removing `__enter__` and `__exit__` appears feasible as they are used only in tests, but it is a slightly bigger change, 3. removing `load` is marginally more complex because it handle the special case when a variable name is equal to `None`. | 2020-08-04T20:27:57Z | 2020-09-22T21:12:47Z | 2020-08-05T14:27:51Z | 2020-08-05T14:27:51Z | 1101eca6a50bb832d6812fbe78852dad2f0306cf | 0 | c6392de351687d3ce9405a0aa25bf6d4681bff3d | e1dafe676812409834ccac3418ecf47600b00615 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4310 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests