pull_requests: 447892617

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
447892617 MDExOlB1bGxSZXF1ZXN0NDQ3ODkyNjE3 4219 closed 0 nd-rolling 6815844 - [x] Closes #4196 - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` I noticed that the implementation of nd-rolling is straightforward. The core part is implemented but I am wondering what the best API is, with keeping it backward-compatible. Obviously, it is basically should look like ```python da.rolling(x=3, y=3).mean() ``` A problem is other parameters, `centers` and `min_periods`. In principle, they can depend on dimension. For example, we can have `center=True` only for `x` but not for `y`. So, maybe we allow dictionary for them? ```python da.rolling(x=3, y=3, center={'x': True, 'y': False}, min_periods={'x': 1, 'y': None}).mean() ``` The same thing happens for `.construct` method. ```python da.rolling(x=3, y=3).construct(x='x_window', y='y_window', stride={'x': 2, 'y': 1}) ``` I'm afraid if this dictionary argument was a bit too redundant. Does anyone have another idea? 2020-07-12T12:19:19Z 2020-08-08T07:23:51Z 2020-08-08T04:16:27Z 2020-08-08T04:16:27Z 1d3dee08291c83d13c46c9b4ede99020942df2f1     0 f44dd5db5ee54cb01f1c6cb6a3d662f93932cd1d e04e21d6160f43bc44e999b6f54f9fe4682f9b81 MEMBER   13221727 https://github.com/pydata/xarray/pull/4219  

Links from other tables