pull_requests: 431889644
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 431889644 | MDExOlB1bGxSZXF1ZXN0NDMxODg5NjQ0 | 4135 | closed | 0 | Correct dask handling for 1D idxmax/min on ND data | 20629530 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #4123 - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Based on comments on dask/dask#3096, I fixed the dask indexing error that occurred when `idxmax/idxmin` were called on ND data (where N > 2). Added tests are very simplistic, I believe the 1D and 2D tests already cover most cases, I just wanted to test that is was indeed working on ND data, assuming that non-dask data was already treated properly. I believe this doesn't conflict with #3936. | 2020-06-09T15:36:09Z | 2020-06-25T16:09:59Z | 2020-06-25T03:59:52Z | 2020-06-25T03:59:51Z | f4638afe009fde5f53de1a1b80cc71f62593c463 | 0 | 76e82e90948aae14f170c595dc2ee61fdf1770cf | fb5fe79a2881055065cc2c0ed3f49f5448afdf32 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4135 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests