pull_requests: 424048387
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 424048387 | MDExOlB1bGxSZXF1ZXN0NDI0MDQ4Mzg3 | 4099 | closed | 0 | Allow non-unique and non-monotonic coordinates in get_clean_interp_index and polyfit | 20629530 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Pull #3733 added `da.polyfit` and `xr.polyval` and is using `xr.core.missing.get_clean_interp_index` in order to get the fitting coordinate. However, this method is stricter than what polyfit needs: as in `numpy.polyfit`, non-unique and non-monotonic indexes are acceptable. This PR adds a `strict` keyword argument to `get_clean_interp_index` so we can skip the uniqueness and monotony tests. `ds.polyfit` and `xr.polyval` were modified to use that keyword. I only added tests for `get_clean_interp_index`, could add more for `polyfit` if requested. | 2020-05-27T18:48:58Z | 2020-06-05T15:46:00Z | 2020-06-05T15:46:00Z | 2020-06-05T15:46:00Z | 09df5ca4036d84620373fa4bccd11d1f1d4bec28 | 0 | fedfbf5ccdf52cac82ac0c072ae8882d630a2f51 | e5cc19cd8f8a69e0743f230f5bf51b7778a0ff96 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4099 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests