pull_requests: 416544318
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 416544318 | MDExOlB1bGxSZXF1ZXN0NDE2NTQ0MzE4 | 4053 | closed | 0 | Fix html repr in untrusted notebooks (plain text fallback) | 4160723 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #4041 - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API This is not very elegant (actually plain text repr is already included in the notebook as `text/plain` mime type but it is ignored when `text/html` mime type is present), but it seems to work. I haven't found a better workaround. I don't really know if this can be properly tested (I only added a basic test). Steps to test this fix: - To "untrust" a notebook: open an existing notebook with a simple editor, manually edit one output cell with a xarray object repr, and save the ipynb file. - Open this notebook with the Notebook app, you should see the plain text repr. | 2020-05-12T07:38:22Z | 2022-03-29T07:10:07Z | 2020-05-20T17:06:40Z | 2020-05-20T17:06:40Z | cb90d5542bd6868d5548ae8efb5815c249c2c329 | 0 | 39299e9f8e71b34ba4587800658204f5b66d9576 | 3e5dd6ef32b9c69806af69a3a5168edcf3b2e21f | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4053 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests