pull_requests: 411421823
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 411421823 | MDExOlB1bGxSZXF1ZXN0NDExNDIxODIz | 4017 | closed | 0 | Combining attrs of member DataArrays of Datasets | 3958036 | While looking at #4009, I noticed that the `combine_attrs` kwarg to `concat` or `merge` only affects the global attrs of the `Dataset`, not the attrs of `DataArray` or `Variable` members of the `Dataset`s being combined. I think this is a bug. So far this PR adds tests that reproduce the issue in #4009, and the issue described above. Fixing should be fairly simple: for #4009 pass `combine_attrs="drop"` to `combine_by_coords` and `combine_nested` in `open_mfdataset`; for this issue insert the `combine_attrs` handling in an appropriate place - possibly in `merge.unique_variable`. I'll update with fixes when I get a chance. - [ ] Closes #4009 - [x] Tests added - [ ] Passes `isort -rc . && black . && mypy . && flake8` - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2020-04-30T12:23:10Z | 2021-05-05T16:37:25Z | 2021-05-05T16:37:25Z | 08dc29d52e8b2a205cf7f86a179c862027cdd313 | 0 | 9ae7d97b6f89e6449faf8e8e0d3957450bc19927 | 7bf9df9d75c40bcbf2dd28c47204529a76561a3f | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4017 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests