pull_requests: 397320781
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
397320781 | MDExOlB1bGxSZXF1ZXN0Mzk3MzIwNzgx | 3925 | closed | 0 | sel along 1D non-index coordinates | 35968931 | As a user, I find not being able to select along one-dimensional non-dimensional coordinates actually comes up fairly often. I think it's quite common to use multiple coordinates to be able to choose between plotting in different coordinate systems (or units) easily. I've tried to close #2028 in the simplest (but also least efficient) way which was suggested by @shoyer ([suggestion 1 here](https://github.com/pydata/xarray/issues/934#issuecomment-236960237)). This should be temporary anyway: it will get superseded by the [explicit indexes refactor](https://github.com/pydata/xarray/issues/1603). If there is another approach which would achieve the same functionality as this PR but actually bring us closer to #1603 then I would be happy to take a stab at that instead. I don't really know what to do about the [failing test](https://github.com/pydata/xarray/blob/b3bafeefbd6e6d70bce505ae1f0d9d5a2b015089/xarray/tests/test_dataset.py#L3632) in groupby arithmetic - I think it's [caused here](https://github.com/pydata/xarray/blob/b3bafeefbd6e6d70bce505ae1f0d9d5a2b015089/xarray/core/groupby.py#L497) but I'm not sure what to replace the triple error type catching (?!) with. - [x] Closes #2028 - [x] Tests added - [ ] Passes `isort -rc . && black . && mypy . && flake8` - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2020-04-02T02:23:56Z | 2022-09-07T14:31:58Z | 2022-09-07T14:31:58Z | a14cfae1f3083d3eb01a105f573dbbcf93966c6e | 0 | 558721e71da2b627028ebc533887c0e6e7a30db5 | d1e4164f3961d7bbb3eb79037e96cae14f7182f8 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/3925 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests