pull_requests: 391346943
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 391346943 | MDExOlB1bGxSZXF1ZXN0MzkxMzQ2OTQz | 3871 | closed | 0 | Implement idxmax and idxmin functions | 2272878 | This implements `idxmax` and `idxmin` functions similar to thier pandas equivalents. This is my first time contributing to the project so I am not certain the structure or approach is the best. Please let me know if there is a better way to implement this. This also includes two other changes. First, it drops some code for backwards-compatibility with numpy 1.12, which isn't supported. This code was hiding an error I needed to have access to in order to get the function working. Second, it adds an option to `Dataset.map` to let you map `DataArray` methods by name. I used this to implement the `Dataset` versions of `idxmax` and `idxmin`. - [X] Closes #60 - [X] Tests added - [X] Passes `isort -rc . && black . && mypy . && flake8` - [X] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2020-03-20T04:27:32Z | 2020-03-31T15:43:48Z | 2020-03-29T01:54:25Z | 2020-03-29T01:54:25Z | 1416d5ae475c0875e7a5d76fa4a8278838958162 | 0 | c2968011474fb25569b208205993875e77b39a1d | ca6bb8561f2977509fc5bf53eae0efd080c0a952 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/3871 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests