pull_requests: 385211775
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 385211775 | MDExOlB1bGxSZXF1ZXN0Mzg1MjExNzc1 | 3847 | closed | 0 | provide a error summary for assert_allclose | 14808389 | right now, unlike `assert_identical` and `assert_equals`, `assert_allclose` simply prints the mismatching data without providing a summary about what failed. This tries to fix that by allowing the `compat` parameter to `formatting.diff_array_repr` and `formatting.diff_dataset_repr` to be a callable and by rewriting `assert_allclose` to only have one assert statement per type. - [x] Closes #3617, closes #1690? - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API There are still more tests to write but I would like to get early feedback about this approach vs. adding a `"allclose"` compat type in addition to the existing `"equals"` and `"identical"` to the formatting functions. | 2020-03-08T01:06:20Z | 2020-06-13T17:53:08Z | 2020-06-13T17:53:03Z | 2020-06-13T17:53:03Z | 2ba530026fb273a2882869a6e09ede053a0f081b | 0 | 1b268516ae29fd3bc9f017a3b5340b95bcf1eb3e | 8051c47686ae23062f9008785563d62327735002 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/3847 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests