pull_requests: 364359492

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
364359492 MDExOlB1bGxSZXF1ZXN0MzY0MzU5NDky 3706 closed 0 Pint support for variables 14808389 I realized that most of the operations depend on `Variable`, which means that this should be the first step to making the other tests pass. This PR copies from #3611, making that PR a work-in-progress again until I remove those parts. - [x] Closes #3783 - [x] Passes `black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API These are the current failures: * `np.prod`: not implemented by `pint` yet, but should work once it is * comparisons: `identical` fails to detect same value, but in different units (like `1 m` and `100 cm`) as different. This is hard to implement in a way that does not include `isinstance` or `hasattr` checks. * `rank`: not implemented for non-ndarrays, so maybe we should mark this as `skip`? * `rolling_window`: `nputils._rolling_window` uses `np.lib.stride_tricks.as_strided`, which cannot be overridden by `pint`. We probably have to use something different? * `shift`: ~this tries to trim, then concatenate a filled array, but I think this should use `np.pad` after trimming? Are there any disadvantages to that?~ it uses `numpy.pad` now which is supported since `dask==0.18` or `dask==0.19` * `concat`: ~this was a misconception on my part, I didn't realize this was a classmethod. After fixing that this still fails because I assumed `Variable.concat` used the dimension names to reshape the arrays. It does not, so this fails:~ I rewrote the test to pass arrays that don't cause the failure ```python xr.Variable.concat([xr.Variable(("x", "y"), ...), xr.Variable(("y", "z"), ...)], dim="y") ``` * `pad_with_fill_value`: ~I think this is a bug in `pint` (see hgrecco/pint#992)~ fixed on pint master Does anyone have any comments on these before I start fixing them? @dcherian? 2020-01-17T23:36:45Z 2020-02-24T00:09:54Z 2020-02-23T19:13:08Z 2020-02-23T19:13:08Z 47476eb400497215b114c2abddc457a057205f63     0 b51caa42d05566d1fe41d8bd155a9f2195b9e96a 52ee5dfe73b51b55cc90f2140f2cd54a2e7946a0 MEMBER   13221727 https://github.com/pydata/xarray/pull/3706  

Links from other tables