pull_requests: 341790366
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 341790366 | MDExOlB1bGxSZXF1ZXN0MzQxNzkwMzY2 | 3544 | open | 0 | Open dataset cf options conflict solving | 5948670 | It took some time*, but here is a suggestion to solve option conflicts in xarray.open_dataset(). If any of the options `mask_and_scale`, `decode_times`, `concat_characters`, or `decode_coords` is manually set and contradicts the manually set choice of `decode_cf` a `ValueError` will be raised. This commit requires to change some option default values of open_dataset() parameters from `True` to `None`. I hope this is acceptable. - [x] Closes #3020 - [x] Tests added - [x] Passes `black . && flake8` (`mypy`passes in principle, but backends/api.py:21 has an unrelated error) - [x] Fully documented, - [ ] including `whats-new.rst` for all changes and `api.rst` for new API What do you think? Do I have to add something to `whats-new.rst` and `api.rst`? PS: (*) This is my first PR of this kind and I wanted to build it in a proper testing environment, but I had to set this up first. | 2019-11-16T20:43:39Z | 2022-06-09T14:50:17Z | 6a671eb4f37fe06cc0cc1bf9dccb36fb7b28b1a5 | 0 | 04f926e40c62ea957a23946817d893dcf3ff52ce | d1e4164f3961d7bbb3eb79037e96cae14f7182f8 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/3544 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests