pull_requests: 320551884
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 320551884 | MDExOlB1bGxSZXF1ZXN0MzIwNTUxODg0 | 3336 | open | 0 | Provide better error message when dimension name matches argument | 2818208 | WIP PR for https://github.com/pydata/xarray/issues/3324. Since `either_dict_or_kwargs` is called 57 times, I don't want to modify every function call without a preliminary review. My main question is if using `locals()` at the top of each function is considered acceptable. Of course, if `locals()` is called _after_ some local variables are created, this code could raise an error when no conflict exists. But explicitly passing in the function argument names in all 57 functions seems brittle. I'd appreciate any thoughts on the PR before I modify all the functions and write some tests. | 2019-09-24T02:16:05Z | 2023-12-02T02:53:11Z | 2a024492c72f67d934aaee1c10329bdbbd6847ee | 0 | dfb9f9399ad1046f5cc7f4959c18e30bc0314266 | d1e4164f3961d7bbb3eb79037e96cae14f7182f8 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/3336 |
Links from other tables
- 3 rows from pull_requests_id in labels_pull_requests