pull_requests: 320078345
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
320078345 | MDExOlB1bGxSZXF1ZXN0MzIwMDc4MzQ1 | 3333 | closed | 0 | More doc fixes | 14808389 | While going through the docs, I noticed several issues: * in `reshaping.rst`, a code block gets hidden because of a missing newline * in `api.rst`, the section `What parts of xarray are considered public API?` is referenced (I think), but the link is broken. * the code samples in `DataArray.plot` are not recognized as such because of missing newlines * the documentation of `Dataset.plot.scatter` in the API reference is broken This PR tries to fix all of those, but while the first three issues are easy to fix, I'm not sure whether my proposed fix for the one involving `scatter` is correct: I've added `plot.dataset_plot.scatter` to `plot.__all__` (exposing `xr.plot.scatter`) and changed `api.rst` to reference `plot.scatter` instead of `Dataset.plot.scatter`. It seems harmless to me, but the information that `scatter` only exists for `Dataset` is less visible. Is that the way to fix this? - [x] Passes `black . && mypy . && flake8` - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2019-09-22T20:09:36Z | 2019-09-23T10:46:34Z | 2019-09-23T01:08:43Z | 2019-09-23T01:08:43Z | 6ec1da202e5abaf317f49ba8dda348ef572b279d | 0 | ee9a05eb8e57429c90cea9075608c75ae10cc525 | a5fe56a081ef59a7fffd1408bb18df2c9dfb4d1e | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/3333 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests