pull_requests: 29783867

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
29783867 MDExOlB1bGxSZXF1ZXN0Mjk3ODM4Njc= 330 closed 0 Improved error handling for datetime decoding errors 1217238 Fixes #323 We now get an error message with a lovely traceback when opening a dataset with invalid time units. For example: ``` Traceback (most recent call last): File "/Users/shoyer/dev/xray/xray/test/test_conventions.py", line 340, in test_invalid_units_raises_eagerly decode_cf(ds) File "/Users/shoyer/dev/xray/xray/conventions.py", line 775, in decode_cf decode_coords) File "/Users/shoyer/dev/xray/xray/conventions.py", line 716, in decode_cf_variables decode_times=decode_times) File "/Users/shoyer/dev/xray/xray/conventions.py", line 676, in decode_cf_variable data = DecodedCFDatetimeArray(data, units, calendar) File "/Users/shoyer/dev/xray/xray/conventions.py", line 340, in __init__ raise ValueError(msg) ValueError: unable to decode time units 'foobar since 123' with the default calendar. Try opening your dataset with decode_times=False. Full traceback: Traceback (most recent call last): File "/Users/shoyer/dev/xray/xray/conventions.py", line 331, in __init__ decode_cf_datetime(example_value, units, calendar) File "/Users/shoyer/dev/xray/xray/conventions.py", line 130, in decode_cf_datetime delta = _netcdf_to_numpy_timeunit(delta) File "/Users/shoyer/dev/xray/xray/conventions.py", line 72, in _netcdf_to_numpy_timeunit return {'seconds': 's', 'minutes': 'm', 'hours': 'h', 'days': 'D'}[units] KeyError: 'foobars' ``` Also includes a fix for a datetime decoding issue reported on the mailing list: https://groups.google.com/forum/#!topic/xray-dev/Sscsw5dQAqQ 2015-02-23T03:08:40Z 2015-02-25T22:00:36Z 2015-02-23T03:11:03Z 2015-02-23T03:11:03Z bb0ea831d39f861ab41767681078f90f73e50664   799013 0 ad346cea7831c6f53215ef60c28d7c17d1860e1d e82835013595795c50656bc66b586b751227c204 MEMBER   13221727 https://github.com/pydata/xarray/pull/330  

Links from other tables