pull_requests: 282140537
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 282140537 | MDExOlB1bGxSZXF1ZXN0MjgyMTQwNTM3 | 2989 | closed | 0 | Add strftime() to datetime accessor with cftimeindex and dask support | 6145107 | - [x] Closes #2090 - [x] Tests added - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API - [x] Add further examples to User Guide Docs Building on #2144, I added dask support and returning the appropriate object type. The two initial commits show alternate approach to handling cftime values. Either adding strftime to `cftimeindex` and accessing that way (commit 5de4db1) or just rolling the loop within the datetime accessor and not touching `cftimeindex` at all ( 51239c9). can revert commit 5de4db1 if its preferred to not touch `cftimeindex` for any reason. Can clean up docstrings and minor formatting after some input on the implementation details. Is there a vectorized or better method for the cftime values? List comprehension was the best I could come up with, borrowing from similar logic elsewhere in the code. | 2019-05-24T19:52:42Z | 2019-06-01T07:51:43Z | 2019-06-01T07:51:17Z | 2019-06-01T07:51:17Z | 74e5ff64171e84a2da3984f512d2134a233240e2 | 0 | 9b8bc0147d48625fdd54177532f4dbb26c397c18 | 0811141e8f985a1f3b95ead92c3850cc74e160a5 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/2989 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests