home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 279578380

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
279578380 MDExOlB1bGxSZXF1ZXN0Mjc5NTc4Mzgw 2968 closed 0 Add examples for `DataArrayRolling.reduce()` 223250 * ~~When reducing over a rolling window, `DataArrayRolling.reduce()` only returns values where the complete rolling window is fully conatined within the base array; the remaining locations where the window overlaps the array border are filled with `NaN`~~ * ~~However, in some situations, it is desirable to obtain values from the reducer function for all locations. This commit adds a keyword argument, `include_border`, to `DataArrayRolling.reduce()` and `DataSetRolling.reduce()` to allow this behavior.~~ ~~If this seems okay, I have some questions:~~ ~~1. Should this behavior be added to specific reducing functions (sum, mean, etc.)? As an alternative, all of the specialized functions for `DataArrayRolling` have corresponding numpy `nan*` functions, so support could be added for those. (The current PR is still useful for other reducing functions, which is my use case.)~~ ~~2. I don't use dask, so I don't know if this is needed/desired for the dask versions of these functions.~~ As @mathause pointed out, the functionality desired already exists by passing `min_periods=1` to `DataArray.rolling()`. So this MR has been updated to simply include some examples for `DataArrayRolling.reduce()` 2019-05-16T16:17:00Z 2019-06-04T14:47:09Z 2019-06-04T14:47:08Z 2019-06-04T14:47:08Z f84c514175f4858caf7dbf2afd2d8fe551208fa0     0 03890602c837418cb6fbcdf56c0f5de20dbba61c 5b3a41d5761edb2240df5a4475196e4939b33719 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/2968  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.939ms