pull_requests: 278088105
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 278088105 | MDExOlB1bGxSZXF1ZXN0Mjc4MDg4MTA1 | 2956 | closed | 0 | Picking up #1118: Do not convert subclasses of `ndarray` unless required | 14808389 | This picks up the work done in #1118, plus converting the `unittest` based tests to `pytest` (since that seems to be used in the other tests). closes #1118 Some of the suggestions there are not implemented yet: * the disabling of bottleneck if a `ndarray` subclass is used * testing for operations like `xarray.concat`. This does not work with any of the unit libraries (at least, `pint`, `astropy.units`, `unyt` and `quantities` don't support it yet). * testing with other unit libraries that use subclasses (e.g. `astropy.units` or `unyt`) * renaming the test file to `test_units_subclass.py` * fix indexing (`NumpyIndexingAdapter`) The requirements files for CI changed since then, so maybe more than the two right now need the `quantities` entry. | 2019-05-12T23:12:43Z | 2019-12-25T14:14:00Z | 2019-12-25T14:11:45Z | 778c5347b13cd2252ccf532b8281ef8419d2c026 | 0 | c4d8512154ab9248f6383fcd08abdaf7fd7a168f | 5f55d41a05618e6091061dfb83fe745ed6008997 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/2956 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests