pull_requests: 271482280
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 271482280 | MDExOlB1bGxSZXF1ZXN0MjcxNDgyMjgw | 2905 | closed | 0 | Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute | 1700203 | This change was prompted by the fact that `getattr(data, 'values', data)` affected any kind of data with a `values` attribute, which is not the desired behaviour for `core.variable.as_compatible_data`. This also extends tests to assert that custom objects with such an attribute are not attempted to be converted. I'm happy to write additional tests, if you could briefly sketch further requirements. - [x] Implemented the changes - [x] Closes #2097 - [x] Tests added - [ ] Sufficient? - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2019-04-17T21:52:37Z | 2021-02-18T17:22:16Z | 2021-02-18T15:04:14Z | 2021-02-18T15:04:14Z | c9b9eec73a033e275b6012e7d391dd42591ccf52 | 0 | ad71bb2da711434989f872531c220c3bbe9374d5 | 7c4e2ac83f7b4306296ff9b7b51aaf016e5ad614 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/2905 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests