pull_requests: 263654744
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 263654744 | MDExOlB1bGxSZXF1ZXN0MjYzNjU0NzQ0 | 2843 | closed | 0 | Allow passing _FillValue=False in encoding for vlen str variables. | 22566757 | <!-- Feel free to remove check-list items aren't relevant to your change --> The documentation seems to imply that passing _FillValue=False in the encoding works to set no fill value for any value. These changes to `netCDF4_.py` and `h5netcdf_.py` seem to allow this for variables that are vlen strings (dtype `str` rather than `"S1"`): I have used the code-path in `netCDF4_.py` in real code and know that it at least allows the save to complete. Allowing _FillValue=False makes it easier to explicitly exclude `_FillValue` from being written for coordinate variables, which some CF-compliance checkers complain about. - [ ] Closes #xxxx - [X] Tests added - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API | 2019-03-22T15:20:27Z | 2019-03-30T14:04:30Z | 2019-03-30T14:04:13Z | 630e5af32173b0368ff3dce2340f0b94dee58b5a | 0 | 101f261f1280b5f6b02be7899d77d969db096972 | 742ed3984f437982057fd46ecfb0bce214563cb8 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/2843 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests