pull_requests: 240872035

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
240872035 MDExOlB1bGxSZXF1ZXN0MjQwODcyMDM1 2633 closed 0 Fix dayofweek and dayofyear attributes from dates generated by cftime_range 6628425 - [x] Tests added It turns out there was a remaining bug in cftime (https://github.com/Unidata/cftime/issues/106) that impacted the results of the `dayofwk` and `dayofyr` attributes of cftime objects generated by their `replace` method, which we use when parsing dates from strings, and in some offset arithmetic. A workaround is to add a `dayofwk=-1` argument to each `replace` call where the `dayofwk` or `dayofyr` would be expected to change. I've fixed this bug upstream in cftime (https://github.com/Unidata/cftime/pull/108), but it will only be available in a future version. Would it be appropriate to use this workaround in xarray? This would fix [this doc page](http://xarray.pydata.org/en/latest/time-series.html#non-standard-calendars-and-dates-outside-the-timestamp-valid-range) for instance: <img width="709" alt="screen shot 2018-12-25 at 7 40 30 am" src="https://user-images.githubusercontent.com/6628425/50422387-7fed3480-0818-11e9-8244-9533b6030691.png"> 2018-12-25T12:57:13Z 2018-12-28T22:55:55Z 2018-12-28T19:04:50Z 2018-12-28T19:04:50Z a8e5002ab616e43f2e1b19a5963475a8275b0220     0 30d9d074d7cc83c51e4b118757cc4dd45b11812a 2667deb74a30dc3bd88752a3ce5da590cf7ddd48 MEMBER   13221727 https://github.com/pydata/xarray/pull/2633  

Links from other tables