pull_requests: 236306204

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
236306204 MDExOlB1bGxSZXF1ZXN0MjM2MzA2MjA0 2593 closed 0 CFTimeIndex Resampling 8708062 I would appreciate some feedback on why this implementation for CFTimeIndex resampling doesn't match pandas' output 100%. - [x] Tentative attempt at addressing #2191 (resampling CFTimeIndex). Downsampling produces results that match pandas' results in all the tests done thus far. However, upsampling has trouble assigning the right values to the right bins. - [x] Tests (`test_cftimeindex_resample.py`) created for standard calendars but not for non-standard calendars (360 days etc.). Contents from `test_cftimeindex_resample.py` will be inserted into `test_dataarray.py` and `test_cftimeindex_resample.py` will be deleted once resampling implementation is finalized. Files found in the `tests/temp` folder is meant to highlight resampling discrepancies between pandas and this implementaion. Both the files and the folder will be removed once resampling implementation is finalized. - [x] Not fully documented. Docstrings have yet to be added to `resample_cftime.py`. There were no doctrings from https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py (which is where the codes were ported from) that could be conveniently copied. 2018-12-05T20:08:06Z 2019-02-03T03:21:29Z 2019-02-03T03:21:14Z 2019-02-03T03:21:14Z d8ff0790b743a814cc3d6c29e24b7257c7480153     0 ef689607fb6c73a7f2c6e3f63b0090a4cd5f52cf 0da9d627d567ea1cb5e733f892930863bd6b630d CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/2593  

Links from other tables