pull_requests: 227443527
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
227443527 | MDExOlB1bGxSZXF1ZXN0MjI3NDQzNTI3 | 2532 | closed | 0 | [WIP] Fix problem with wrong chunksizes when using rolling_window on dask.array | 102827 | - [ ] Closes #2514 - [ ] Closes #2531 - [ ] Tests added (for all bug fixes or enhancements) - [ ] Fully documented, including `whats-new.rst` for all changes ## Short summary The two rolling-window functions for `dask.array` * [dask_rolling_wrapper](https://github.com/pydata/xarray/blob/b622c5e7da928524ef949d9e389f6c7f38644494/xarray/core/dask_array_ops.py#L23) * [rolling_window](https://github.com/pydata/xarray/blob/b622c5e7da928524ef949d9e389f6c7f38644494/xarray/core/dask_array_ops.py#L43) will be fixed to preserve `dask.array` chunksizes. ## Long summary The specific initial problem with chunksizes and `interpolate_na()` in #2514 is caused by the padding done in https://github.com/pydata/xarray/blob/5940100761478604080523ebb1291ecff90e779e/xarray/core/dask_array_ops.py#L74-L85 which adds a small array with a small chunk to the initial array. There is another related problem where `DataArray.rolling()` changes the size and distribution of `dask.array` chunks which stems from this code https://github.com/pydata/xarray/blob/b622c5e7da928524ef949d9e389f6c7f38644494/xarray/core/dask_array_ops.py#L23 For some (historic) reason there are these two rolling-window functions for `dask`. Both need to be fixed to preserve chunksize of a `dask.array` in all cases. | 2018-10-31T21:12:03Z | 2021-03-26T19:50:50Z | 2021-03-26T19:50:50Z | efc36181613b0fb29d2f67b2ef40f1e463fd133f | 0 | 8a4e5904ccede22565a51dc3775b99d713df6259 | 7bf9df9d75c40bcbf2dd28c47204529a76561a3f | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/2532 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests