pull_requests: 223943573
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 223943573 | MDExOlB1bGxSZXF1ZXN0MjIzOTQzNTcz | 2492 | closed | 0 | ENH: Detect the GRIB files by the filename extension and suggest engine. | 226037 | `_get_default_engine` chooses the engine suitable to open the `path`, ATM it only detects URL's. In this PR I propose to also detect GRIB files by the extension and suggest to the user which `engine` to use. **Updated:** The whole engine detection strategy looked a bit fragile as the `.gz` extension was recognised outside of `_get_default_engine` and the nested `if`s and `try` / `except` blocks make the code poorly readable. I added a bit of a refactor in this area. - ~~Closes xxxx~~ - [x] Tests added - ~~Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API.~~ No change to document. | 2018-10-18T12:50:13Z | 2018-10-25T20:57:38Z | 2018-10-22T15:26:14Z | 2018-10-22T15:26:14Z | 671d936166414edc368cca8e33475369e2bb4d24 | 0 | 486a391915d3bf1af685ae9ef908c30d5e053851 | 9f4474d657193f1c7c9aac25bb2edf94755a8593 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/2492 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests