pull_requests: 206807293

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
206807293 MDExOlB1bGxSZXF1ZXN0MjA2ODA3Mjkz 2351 closed 0 Remove redundant code from open_rasterio and ensure all transform tuples are six elements long 296686 - [x] Closes #2348 - [x] Tests added (for all bug fixes or enhancements) - [x] Tests passed (for all non-documentation changes) - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later) This removes the redundant code that ended up with the `transform` attribute being set twice - and being set to a nine-element long tuple rather than the correct six-element long tuple. It also adds tests to ensure that all `transform` attributes are six-element-long tuples. I haven't made any changes to the documentation, as I wasn't sure if it was needed. This could potentially affect users as the documentation and the code differed and people may have written other interface code (as, in my case, code to export a DataArray to a GeoTIFF using rasterio) which relies on the transform element having 9 elements rather than the 6 it is meant to have. Any thoughts? 2018-08-07T19:48:39Z 2018-08-13T22:34:18Z 2018-08-13T22:33:54Z 2018-08-13T22:33:54Z 4df048c146b8da7093faf96b3e59fb4d56945ec5     0 0cc248853877feceff70506e39cb8f3228684b12 0a60a52521e41dce897e265ac549cbf88c670faa CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/2351  

Links from other tables