pull_requests: 204506186
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 204506186 | MDExOlB1bGxSZXF1ZXN0MjA0NTA2MTg2 | 2322 | closed | 0 | BUG: modify behavior of Dataset.filter_by_attrs to match netCDF4.Data… | 868027 | Here is my fix for #2315 which matches the behavior of Dataset.filter_by_attrs to be that of its netCDF4 inspiration. I followed the pattern seen in the netCDF4 library which set a boolean flag while looping over attributes and short circuits the loop if any test returns false. Only if all the ``key=value/callable`` tests pass is the variable added to the output. - [x] Closes #2315 - [x] Tests added (for all bug fixes or enhancements) - [x] Tests passed (for all non-documentation changes) - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later) | 2018-07-27T18:25:42Z | 2018-08-28T01:48:00Z | 2018-08-28T01:21:20Z | 2018-08-28T01:21:20Z | 78c57bb5234b1446182755523fcaa58494eab640 | 0 | 23329117877f2a036f77ada7f29a82619ebc90c3 | 56381ef444c5e699443e8b4e08611060ad5c9507 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/2322 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests