pull_requests: 189263277
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
189263277 | MDExOlB1bGxSZXF1ZXN0MTg5MjYzMjc3 | 2166 | closed | 0 | Fix string slice indexing for a length-1 CFTimeIndex | 6628425 | - [x] Closes #2165 - [x] Tests added (for all bug fixes or enhancements) - [x] Tests passed (for all non-documentation changes) - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later) The issue is that both `is_monotonic_decreasing` and `is_monotonic_increasing` return `True` for a length-1 index; therefore an additional check is needed to make sure the length of the index is greater than 1 in `CFTimeIndex._maybe_cast_slice_bound`. This is similar to how things are done in [`DatetimeIndex._maybe_cast_slice_bound`](https://github.com/pandas-dev/pandas/blob/master/pandas/core/indexes/datetimes.py#L1666) in pandas. | 2018-05-21T01:04:01Z | 2018-05-21T10:51:16Z | 2018-05-21T08:02:35Z | 2018-05-21T08:02:35Z | 48d55eea052fec204b843babdc81c258f3ed5ce1 | 0 | 98061ea8813ac0d701174e5d9ebc7bbfaa24b655 | 585b9a7913d98e26c28b4f1da599c1c6db551362 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/2166 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests