pull_requests: 1851405647
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1851405647 | PR_kwDOAMm_X85uWjVP | 8993 | closed | 0 | call `np.cross` with 3D vectors only | 14808389 | - [x] towards #8844 In the tests, we've been calling `np.cross` with vectors of 2 or 3 dimensions, `numpy>=2` will deprecate 2D vectors (*plus*, we're now raising on warnings). Thus, we 0-pad the inputs before generating the expected result (which generally should not change the outcome of the tests). For a later PR: add tests to check if `xr.cross` works if more than a single dimension is present, and pre-compute the expected result. Also, for property-based testing: the cross-product of two vectors is perpendicular to both input vectors (use the dot product to check that), and its length (l2-norm) is the product of the lengths of the input vectors. | 2024-05-02T12:21:30Z | 2024-05-03T15:56:49Z | 2024-05-03T15:22:26Z | 2024-05-03T15:22:25Z | aaa778cffb89baaece31882e03a7f4af0adfe798 | 0 | 49f4a392ce4abf979d434e088925c41412280cb4 | 748bb3a328a65416022ec44ced8d461f143081b5 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/8993 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests