pull_requests: 1832729498

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1832729498 PR_kwDOAMm_X85tPTua 8960 closed 0 Option to not auto-create index during expand_dims 35968931 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Solves part of #8871 by pulling out part of https://github.com/pydata/xarray/pull/8872#issuecomment-2027571714 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] ~~New functions/methods are listed in `api.rst`~~ TODO: - [x] Add new kwarg to `DataArray.expand_dims` - [ ] Add examples to docstrings? - [x] Check it actually solves the problem in #8872 2024-04-20T03:27:23Z 2024-04-27T16:48:30Z 2024-04-27T16:48:24Z 2024-04-27T16:48:24Z 214d9417eb525ff10cc3ef90d9838fc42eef5b64     0 6bde1587a0da18f856c1f1e12425475ce8f99d30 d7edbd754627ecdcfb4de1e061126f37add248c6 MEMBER 
{
    "enabled_by": {
        "login": "TomNicholas",
        "id": 35968931,
        "node_id": "MDQ6VXNlcjM1OTY4OTMx",
        "avatar_url": "https://avatars.githubusercontent.com/u/35968931?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/TomNicholas",
        "html_url": "https://github.com/TomNicholas",
        "followers_url": "https://api.github.com/users/TomNicholas/followers",
        "following_url": "https://api.github.com/users/TomNicholas/following{/other_user}",
        "gists_url": "https://api.github.com/users/TomNicholas/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/TomNicholas/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/TomNicholas/subscriptions",
        "organizations_url": "https://api.github.com/users/TomNicholas/orgs",
        "repos_url": "https://api.github.com/users/TomNicholas/repos",
        "events_url": "https://api.github.com/users/TomNicholas/events{/privacy}",
        "received_events_url": "https://api.github.com/users/TomNicholas/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "Option to not auto-create index during expand_dims (#8960)",
    "commit_message": "* test expand_dims doesn't create Index\r\n\r\n* add option to not create 1D index in expand_dims\r\n\r\n* refactor tests to consider data variables and coordinate variables separately\r\n\r\n* fix bug causing new test to fail\r\n\r\n* test index auto-creation when iterable passed as new coordinate values\r\n\r\n* make test for iterable pass\r\n\r\n* added kwarg to dataarray\r\n\r\n* whatsnew\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* update tests to use private versions of assertions\r\n\r\n* create_1d_index->create_index\r\n\r\n* Update doc/whats-new.rst\r\n\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>\r\n\r\n* warn if create_index=True but no index created because dimension variable was a data var not a coord\r\n\r\n* add string marks in warning message\r\n\r\n---------\r\n\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/8960  

Links from other tables