pull_requests: 1816204448
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1816204448 | PR_kwDOAMm_X85sQRSg | 8924 | open | 0 | Keep attributes for "bounds" variables | 28786187 | Issue #2921 is about mismatching time units between a time variable and its "bounds" companion. However, #2965 does more than fixing #2921, it removes all double attributes from "bounds" variables which has the undesired side effect that there is currently no way to save them to netcdf with xarray. Since the mentioned link is a recommendation and not a hard requirement for CF compliance, these attributes should be left to the caller to prepare the dataset variables appropriately if required. Reduces the amount of surprise that attributes are not written to disk and fixes #8368. <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #8368 - [ ] Tests added (simple round trip test would be in issue #8368) - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` (not sure about "user visibility" here) | 2024-04-10T14:29:58Z | 2024-04-11T14:09:48Z | 7bfc111e9786c7aede6169c44fe2531a7f16ed9c | 0 | e8aa5c5235803ee7992b9486137ac548723f1af1 | 07c7f969fe879af7a871374209957d5cd1ddb5aa | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/8924 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests