home / github / pull_requests

Menu
  • GraphQL API
  • Search all tables

pull_requests: 1779870325

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1779870325 PR_kwDOAMm_X85qFqp1 8854 open 0 array api-related upstream-dev failures 14808389 - [x] towards #8844 This "fixes" the upstream-dev failures related to the removal of `numpy.array_api`. There are a couple of open questions, though: - `array-api-strict` is not installed by default, so `namedarray` would get a new dependency. Not sure how to deal with that – as far as I can tell, `numpy.array_api` was not supposed to be used that way, so maybe we need to use `array-api-compat` instead? What do you think, @andersy005, @Illviljan? - `array-api-strict` does not define `Array.nbytes` (causing a funny exception that wrongly claims `DataArray` does not define `nbytes`) - `array-api-strict` has a different `DType` class, which makes it tricky to work with both `numpy` dtypes and said dtype class in the same code. In particular, if I understand correctly we're supposed to check dtypes using `isdtype`, but `numpy.isdtype` will only exist in `numpy>=2`, `array-api-strict`'s version does not define datetime / string / object dtypes, and `numpy.issubdtype` does not work with the non-`numpy` dtype class). So maybe we need to use `array-api-compat` internally? 2024-03-19T13:17:09Z 2024-05-03T22:46:41Z     e7364e823cf5e9debaeceee837ca585d61ade6c9     0 75b3b6d8d59ad4ab66b7797d11068be6d2f4e902 aaa778cffb89baaece31882e03a7f4af0adfe798 MEMBER   13221727 https://github.com/pydata/xarray/pull/8854  

Links from other tables

  • 3 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.665ms