pull_requests: 1775248042
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1775248042 | PR_kwDOAMm_X85p0CKq | 8846 | closed | 0 | Support pandas copy-on-write behaviour | 2448579 | - [x] Closes #8843 - [x] Tests added ```python import numpy as np import pandas as pd pd.set_option("mode.copy_on_write", True) from xarray.core.variable import _possibly_convert_objects string_var = np.array(["a", "bc", "def"], dtype=object) datetime_var = np.array( ["2019-01-01", "2019-01-02", "2019-01-03"], dtype="datetime64[ns]" ) assert _possibly_convert_objects(string_var).flags.writeable assert _possibly_convert_objects(datetime_var).flags.writeable ``` The core issue is that we now get read-only arrays back from pandas here: https://github.com/pydata/xarray/blob/fbcac7611bf9a16750678f93483d3dbe0e261a0a/xarray/core/variable.py#L197-L212 @phofl is this expected? | 2024-03-16T03:14:46Z | 2024-03-18T16:00:15Z | 2024-03-18T16:00:12Z | 2024-03-18T16:00:12Z | c6c01b12e06be53bbcdd3292b3db1d410ea9c21f | 0 | f04b2d798fc276c67f0abdff0f5c1aef1e528f11 | fbcac7611bf9a16750678f93483d3dbe0e261a0a | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/8846 |
Links from other tables
- 3 rows from pull_requests_id in labels_pull_requests