home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 177077159

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
177077159 MDExOlB1bGxSZXF1ZXN0MTc3MDc3MTU5 2011 closed 0 rolling: periodic 10194086 - [x] Closes #2007 - [ ] Tests added (for all bug fixes or enhancements) - [ ] Tests passed (for all non-documentation changes) - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API --- Ok, this was easier to do than initially thought, we can use `np.pad(a, pads, mode='wrap')` in `nputils.rolling_window`. However, I'm not sure if that is enough already<sup>*</sup>. I added an initial test, but could use some pointers where else you want this to be tested. Questions: * is `fill_value='periodic'` a good api? * should the `fill_value` keyvalue be ported to `rolling`? * should this also be mentioned in the docs for `rolling` (I only learned about `rolling.construct` yesterday) --- <sup>*</sup>`rolling` is present in`core/dataset.py`, `core/dataarray.py`, `core/variable.py`, `core/rolling.py`, `core/dask_array_ops.py`, `core/nputils.py`, `core/ops.py`, `core/common.py`, `core/missing.py`, and `core/duck_array_ops.py` that can be a bit daunting... 2018-03-23T13:57:25Z 2021-03-30T15:08:22Z 2021-03-30T15:08:18Z   d04b403053b0d69972bf80fb2963e4b4bbd0a852     0 14e60895629388ff4e038a6144e2cf293a23afd2 7bf9df9d75c40bcbf2dd28c47204529a76561a3f MEMBER   13221727 https://github.com/pydata/xarray/pull/2011  

Links from other tables

  • 1 row from pull_requests_id in labels_pull_requests
Powered by Datasette ยท Queries took 157.997ms