pull_requests: 172975968
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 172975968 | MDExOlB1bGxSZXF1ZXN0MTcyOTc1OTY4 | 1965 | closed | 0 | avoid integer overflow when decoding large time numbers | 3404817 | The issue: `int32` time data in seconds or so leads to an overflow in time decoding. This is in way the back side of #1859: By ensuring that `_NS_PER_TIME_DELTA` is integer, we got rid of round-off errors that were due to casting to float but now we are getting `int` overflow in this line: https://github.com/pydata/xarray/blob/0e73e240107caee3ffd1a1149f0150c390d43251/xarray/coding/times.py#L169-L170 e.g. '2001-01-01' in `seconds since 1970-01-01` means `np.array([978307200]) * int(1e9)` which gives `288686080` that gets decoded to '1970-01-01T00:00:00.288686080' -- note also the trailing digits. Something is very wrong here. - [x] Tests added (for all bug fixes or enhancements) - [x] Tests passed (for all non-documentation changes) - [x] Fully documented, including `whats-new.rst` for all changes | 2018-03-05T20:21:20Z | 2018-05-01T12:41:28Z | 2018-05-01T12:41:28Z | f63ee22022040a325e2965d0fd704454c7f44c78 | 0 | 9f852780219088f2d3efdecf4ec787e00fcf334f | 33095885e6a4d7b2504ced5d9d4d34f1d6e872e2 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/1965 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests