pull_requests: 17157222
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 17157222 | MDExOlB1bGxSZXF1ZXN0MTcxNTcyMjI= | 162 | closed | 0 | Change np.isnan to pd.isnull in conventions.py to handle _FillValue = '' | 4194485 | At a number of spots in conventions.py, np.isnan was being used to check possible fill values. However, np.isnan is not implemented for string types. So, I've replaced np.isnan with pd.isnull. Alas, I haven't been able to update the tests to cover _FillValue = '', because doing so would involve significant changes throughout the code base. | 2014-06-15T23:10:29Z | 2014-06-15T23:16:48Z | 2014-06-15T23:16:35Z | 2014-06-15T23:16:35Z | 17e4ec59af53f58c4f960b2795e059e67a00e9ed | 0 | 57ebf7df62461abbd6b6f5d45a79dda38e6ba001 | 3ccf1a8931780f0a2554253675803df8f8ec6ebd | NONE | 13221727 | https://github.com/pydata/xarray/pull/162 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests