pull_requests: 1709181628
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1709181628 | PR_kwDOAMm_X85l4Aq8 | 8697 | closed | 0 | add open_datatree to xarray | 479480 | Draft: I'd like to open this up and start a discussion on a couple of things. Here is a first stab at adding open_datatree to the backend of xarray. 1. ~~I'm not sure which tests to migrate/write with this change. The only datatree tests that have open_datatree are the ones in tests/test_io.py. While those (and all of the datatree tests) run and pass, they are still located in _datatree, and they don't seem to fit in the test_backends.py. I do see that Tom did a good job of naming the tests so that they would fit with the existing tests in many places.~~ Migrated tests over into xarray/tests/datatree once approved and merged can be added into the existing tests where appropriate [(from Tom)](https://github.com/pydata/xarray/pull/8697#pullrequestreview-1860425936). 2. I was able to open datatrees with each of the engines, netcdf4, h5netcdf and zarr. 3. I haven't moved any documentation. I remember hearing that we could add it and mark it as experimental? Is that the correct way forward? No check boxes checked yet. - [ ] Closes part of first bullet of https://github.com/pydata/xarray/issues/8572 - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2024-02-02T20:20:03Z | 2024-02-14T23:41:03Z | 2024-02-14T21:50:29Z | 2024-02-14T21:50:29Z | fffb03c8abf5d68667a80cedecf6112ab32472e7 | 0 | e291587f330c1e3772a55d4d6d68e18cd9c4639c | 4806412c7f08480d283f1565262f040bdc74d11d | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/8697 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests