pull_requests: 1693573685

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1693573685 PR_kwDOAMm_X85k8eI1 8651 closed 0 allow negative freq strings 10194086 <!-- Feel free to remove check-list items aren't relevant to your change --> - [ ] Closes #xxxx - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This allows negative freq strings as discussed in https://github.com/pydata/xarray/pull/8627#issuecomment-1905981660 Deciding which tests to update was not easy. The pandas `_generate_range` function was moved to https://github.com/pandas-dev/pandas/blob/3c96b8ff6d399fbec8d4d533e8e8618c592bb64b/pandas/core/arrays/datetimes.py#L2725 They no longer `rollback` the `end`. I had to remove this as well such that the following are eqivalent: ```python xr.date_range("2001", "2000", freq="-1YE", calendar="noleap") pd.date_range("2001", "2000", freq="-1YE") ``` I am slightly nervous about this but all the tests still pass... Once again cc @spencerkclark 2024-01-24T12:04:39Z 2024-02-01T09:17:11Z 2024-02-01T09:01:44Z 2024-02-01T09:01:44Z c9ba2be2690564594a89eb93fb5d5c4ae7a9253c     0 0279bb4f6a676054fe0bd7e03be69e4b2fe59371 4de10d49f97b8c66e4c563a07af3f0a7c25ca3ff MEMBER 
{
    "enabled_by": {
        "login": "mathause",
        "id": 10194086,
        "node_id": "MDQ6VXNlcjEwMTk0MDg2",
        "avatar_url": "https://avatars.githubusercontent.com/u/10194086?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/mathause",
        "html_url": "https://github.com/mathause",
        "followers_url": "https://api.github.com/users/mathause/followers",
        "following_url": "https://api.github.com/users/mathause/following{/other_user}",
        "gists_url": "https://api.github.com/users/mathause/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/mathause/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/mathause/subscriptions",
        "organizations_url": "https://api.github.com/users/mathause/orgs",
        "repos_url": "https://api.github.com/users/mathause/repos",
        "events_url": "https://api.github.com/users/mathause/events{/privacy}",
        "received_events_url": "https://api.github.com/users/mathause/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "allow negative freq strings (#8651)",
    "commit_message": "* allow negative freq strings\r\n\r\n* update docstring\r\n\r\n* fix date_range_like\r\n\r\n* whats-new entry\r\n\r\n* Apply suggestions from code review\r\n\r\nCo-authored-by: Spencer Clark <spencerkclark@gmail.com>\r\n\r\n* only test standard calendar\r\n\r\n* merge tests\r\n\r\n---------\r\n\r\nCo-authored-by: Spencer Clark <spencerkclark@gmail.com>"
}
 13221727 https://github.com/pydata/xarray/pull/8651  

Links from other tables