home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 162776801

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
162776801 MDExOlB1bGxSZXF1ZXN0MTYyNzc2ODAx 1824 closed 0 Make `flake8 xarray` pass 12229877 Closes #1741 by @mrocklin (who did most of the work I'm presenting here). I had an evening free, so I rebased the previous pull on master, fixed the conflicts, and then made everything pass with `flake8`'s default settings (including line length). My condolences to whoever gets to *review* this diff! The single change any non-pedant will notice: Travis now fails if there is a flake8 warning anywhere. My experience in other projects is that this is the only way to actually *keep* flake8 passing - it's just unrealistic to expect perfect attention to detail from every contributor, but "make the build green before we merge" is widely understood 😄 2018-01-13T11:37:43Z 2018-01-14T23:10:01Z 2018-01-14T20:49:20Z 2018-01-14T20:49:20Z 0d69bf9dbf281f0f0f48ac2fadda61a82533aac3     0 5f5a50ad438a080635ae7c8783f3773f83062b5f 502a988ad5b87b9f3aeec3033bf55c71272e1053 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/1824  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 1.026ms