pull_requests: 1600906396
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1600906396 | PR_kwDOAMm_X85fa-Sc | 8450 | open | 0 | Add keep_variables keyword to open_dataset() | 48135565 | This is based on #895 by @tsupinie, following the suggestions on that PR made by @shoyer, but that was so old I decided it was best to do a completely new PR. XArray has changed quite a bit since then, so I had to make changes in several more files than the original PR did in order to get tests to pass. I'm very new to working on XArray, and my approach here was to basically just mirror how the package handles `drop_variables` wherever that appears, with the necessary logical tweaks where appropriate. As such I've possibly touched something that shouldn't be (in particular I'm looking at `xarray/backends/zarr.py` and `xarray/backends/common.py` as places where I'm not quite sure if I've done things properly). - [ ] Closes #1754 - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` | 2023-11-14T15:09:24Z | 2023-11-17T08:27:39Z | a60bd4fcd0513d8ead7d2f7e3bf79e4ff3e7434e | 0 | ed13cc220023cdb9159484356c8e6871b39e533c | 22ca9ba87be071fde18a65f11f0bb4ec83188da4 | FIRST_TIME_CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/8450 |
Links from other tables
- 4 rows from pull_requests_id in labels_pull_requests