pull_requests: 1587405002
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1587405002 | PR_kwDOAMm_X85eneDK | 8415 | closed | 0 | Deprecate certain cftime frequency strings following pandas | 6628425 | Following several upstream PRs in pandas, this PR deprecates cftime frequency strings `"A"`, `"AS"`, `"Q"`, `"M"`, `"H"`, `"T"`, `"S"`, `"L"`, and `"U"` in favor of `"Y"`, `"YS"`, `"QE"`, `"ME"`, `"h"`, `"min"`, `"s"`, `"ms"`, and `"us"`. Similarly following pandas, it makes a breaking change to have `infer_freq` return the latter frequencies instead of the former. There are a few places in the tests and one place in the code where we need some version-specific logic to retain support for older pandas versions. @aulemahal it would be great if you could take a look to make sure that I handled this breaking change properly / fully in the `date_range_like` case. I also took the liberty to transition to using `"Y"`, `"YS"`, `"h"`, `"min"`, `"s"`, `"ms"`, `"us"`, and `"ns"` within our code, tests, and documentation to reduce the amount of warnings emitted. I have held off on switching to `"QE"`, `"ME"`, and anchored offsets involving `"Y"` or `"YS"` in pandas-related code since those are not supported in older versions of pandas. The deprecation warning looks like this: ``` >>> xr.cftime_range("2000", periods=5, freq="M") <stdin>:1: FutureWarning: 'M' is deprecated and will be removed in a future version. Please use 'ME' instead of 'M'. CFTimeIndex([2000-01-31 00:00:00, 2000-02-29 00:00:00, 2000-03-31 00:00:00, 2000-04-30 00:00:00, 2000-05-31 00:00:00], dtype='object', length=5, calendar='standard', freq='ME') ``` <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #8394 - [x] Addresses the `convert_calendar` and `date_range_like` test failures in #8091 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2023-11-05T12:27:59Z | 2023-11-16T15:37:27Z | 2023-11-16T15:19:40Z | 2023-11-16T15:19:40Z | dfe6435c270957b0322e0d31db4f59a257f2d54d | 0 | 6c1995e4c5e36a5b21e568bb286295b453da5110 | 141147434cb1f4547ffff5e28900eeb487704f08 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/8415 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests