pull_requests: 1585155044
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1585155044 | PR_kwDOAMm_X85ee4vk | 8406 | closed | 0 | Add getitem to array protocol | 14371165 | Currently using getitem is not allowed for either a arrayfunction or arrayapi according to the type hints. Add support for it. Issues found in #8344 as more and more typing was added. But getitem is used in main as well which should fail, but manages to pass due to lack of type hints: https://github.com/pydata/xarray/blob/9acc411bc7e99e61269eadf77e96b9ddd40aec9e/xarray/namedarray/core.py#L792 Notes * mypy will now complain for `_arrayapi[None]` or `_arrayapi([None,)]`, use `xp.expand_dims(_arrayapi)` for now instead. https://github.com/numpy/numpy/pull/25022 https://github.com/data-apis/array-api/pull/687 | 2023-11-02T23:02:48Z | 2023-12-12T20:54:00Z | 2023-12-12T20:44:11Z | 2023-12-12T20:44:11Z | 0bf38c223b5f9ce7196198e2d92b6f33ea344e83 | 0 | 3e432b6447ba47ffbf7f6b665e00ac65933da110 | 562f2f86ba5f4c072f63e78b72753145b76bd2db | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/8406 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests