pull_requests: 154241051

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
154241051 MDExOlB1bGxSZXF1ZXN0MTU0MjQxMDUx 1737 closed 0 WIP: 1d+2d coord plotting 2448579 - [ ] Closes #xxxx - [x] Tests added / passed - [x] Passes ``git diff upstream/master **/*py | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API This PR teaches `plot.contourf()` to contour variables with both a 1D co-ordinate (e.g. time) and a 2D co-ordinate (e.g. time-varying depth) `da`: ``` <xarray.DataArray 'S' (z: 5, time: 85646)> array([[ nan, nan, nan, ..., nan, nan, nan], [ 35.02816 , 34.729567, 34.779223, ..., 34.57513 , 34.671975, 34.334675], [ 35.206943, 35.163239, 34.938674, ..., 34.780728, 34.836331, 34.70386 ], [ nan, 35.184057, 35.10592 , ..., 34.656925, 34.776915, 34.429442], [ 34.85562 , 34.81994 , 35.00963 , ..., 35.014522, 34.9747 , 35.033848]]) Coordinates: depth (z, time) float16 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 0.0 53.5 ... * time (time) datetime64[ns] 2013-12-19T06:00:01 2013-12-19T06:10:01 ... Dimensions without coordinates: z ``` Now we can do `da.plot(x='time', y='depth')` Couple of questions: 1. I've added a test, but am not sure how to work in an assert statement. 2. How do I test that I haven't messed up the syntax in `whats-new.rst` 2017-11-22T19:43:34Z 2017-12-19T23:49:39Z 2017-11-29T11:50:09Z 2017-11-29T11:50:09Z 8b08ad853b187aba9cd501704d065f9db7876e51     0 a636088a462d2a530bb00471c26f9a1d168952ba 9d09c1659741dafb1fadeed49c81f9e90a548b07 MEMBER   13221727 https://github.com/pydata/xarray/pull/1737  

Links from other tables