pull_requests: 1500283634
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1500283634 | PR_kwDOAMm_X85ZbILy | 8140 | open | 0 | Deprecate passing pd.MultiIndex implicitly | 4160723 | <!-- Feel free to remove check-list items aren't relevant to your change --> - Follow-up #8094 - [x] Closes #6481 - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This PR should normally raise a warning *each time* when indexed coordinates are created implicitly from a `pd.MultiIndex` object. I updated the tests to create coordinates explicitly using `Coordinates.from_pandas_multiindex()`. I also refactored some parts where a `pd.MultiIndex` could still be passed and promoted internally, with the exception of: - `swap_dims()`: it should raise a warning! Right now the warning message is a bit confusing for this case, but instead of adding a special case we should probably deprecate the whole method? As it is suggested as a TODO comment... This method was to circumvent the limitations of dimension coordinates, which isn't needed anymore (`rename_dims` and/or `set_xindex` is equivalent and less confusing). - `xr.DataArray(pandas_obj_with_multiindex, dims=...)`: I guess it should raise a warning too? - `da.stack(z=...).groupby("z")`: it shoudn't raise a warning, but this requires a (heavy?) refactoring of groupby. During building the "grouper" objects, `grouper.group1d` or `grouper.unique_coord` may still be built by extracting only the multi-index dimension coordinate. I'd greatly appreciate if anyone familiar with the groupby implementation could help me with this! @dcherian ? | 2023-09-03T14:01:18Z | 2023-11-15T20:15:00Z | ddb96c1f3a6fc2bcddea2432af311c5cbfcfc492 | 0 | ef7dae0893f6701a203f8ec3c2e655bff7944b91 | e2b6f3468ef829b8a83637965d34a164bf3bca78 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/8140 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests