pull_requests: 149814156
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 149814156 | MDExOlB1bGxSZXF1ZXN0MTQ5ODE0MTU2 | 1676 | closed | 0 | Support orthogonal indexing in MemoryCachedArray (Fix for #1429) | 6815844 | - [x] Closes #1429 - [x] Tests added / passed - [x] Passes ``git diff upstream/master **/*py | flake8 --diff`` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API This bug originates from the complicated structure around the array wrappers and their indexing, i.e. different array wrappers support different indexing types, and moreover, some can store another array wrapper in it. I made some cleanups. + Now every array wrapper is a subclass of `NDArrayIndexable` + Every array wrapper should implement its own `__getitem__` or just store another `NDArrayIndexable`. I think I added enough test for it, but I am not yet fully accustomed with xarray's backend. There might be many combinations of their hierarchical relation. I would appreciate any comments. | 2017-10-31T15:10:59Z | 2017-11-09T13:47:38Z | 2017-11-06T17:21:56Z | 2017-11-06T17:21:55Z | 2a1d3928a0aa0e66fe0a2211a6c9f1d079404dff | 0 | 7bba356573e778692b397f0d0a095fcc04a40819 | acae757d869af776a4b2bd980fb77a1873f4c510 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/1676 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests