home / github / pull_requests

Menu
  • GraphQL API
  • Search all tables

pull_requests: 1488345780

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
1488345780 PR_kwDOAMm_X85Ytlq0 8111 open 0 Alignment: allow flexible index coordinate order 4160723 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #7002 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This PR relaxes some of the rules used in alignment for finding the indexes to compare or join together. Those indexes must still be of the same type and must relate to the same set of coordinates (and dimensions), but the order of coordinates is now ignored. It is up to the index to implement the equal / join logic if it needs to care about that order. Regarding `pandas.MultiIndex`, it seems that the level names are ignored when comparing indexes: ```python midx = pd.MultiIndex.from_product([["a", "b"], [0, 1]], names=("one", "two"))) midx2 = pd.MultiIndex.from_product([["a", "b"], [0, 1]], names=("two", "one")) midx.equals(midx2) # True ``` However, in Xarray the names of the multi-index levels (and their order) matter since each level has its own xarray coordinate. In this PR, `PandasMultiIndex.equals()` and `PandasMultiIndex.join()` thus check that the level names match. 2023-08-24T16:18:49Z 2023-09-28T15:58:38Z     79103728908c37d32bc902cd7bcc583363ce9bd9     0 0645c4b813908104c27ace51fce16ac053c6e1e8 42d42bab5811702e56c638b9489665d3c505a0c1 MEMBER   13221727 https://github.com/pydata/xarray/pull/8111  

Links from other tables

  • 1 row from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.785ms